simple log in program with database access

**ogimy** · 03-17-2010 1:24 PM

i have make the simple code log in program with connect database.The below code have something problem.Can someone pro solve the problem.

Private Sub btnSignIn_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnSignIn.Click
Dim conn As New OleDb.OleDbConnection
Dim ds As New DataSet
Dim da As New OleDb.OleDbDataAdapter
Dim command As New OleDb.OleDbCommand

conn.ConnectionString = "PROVIDER=Microsoft.Jet.OLEDB.4.0;Data Source = C:\Documents and Settings\Prokiller\My Documents\Visual Studio Projects\in process\New Folder (2)22\username.mdb"

conn.Open()
command.CommandText = "SELECT * FROM [UserName] WHERE TblUserName'" & txtUserName.Text & "' AND Pin= '" & txtPin.Text & "';"
command.Connection = conn

da.SelectCommand = command
da.Fill(ds, "username")

Dim count = ds.Tables(0).Rows.Count

If count > 0 Then
MsgBox("ok")
Form2.Show()
Me.Hide()
Else
MsgBox("invalid")

End If

conn.Close()
End Sub

**Tom** · 03-17-2010 11:15 PM

=
.........

**r3plica** · 03-18-2010 8:07 AM

yeah Tom is right, you are missing the = but you have also said the column rather than the table

Code:

command.CommandText = "SELECT * FROM [UserName] WHERE TblUserName'" & txtUserName.Text & "' AND Pin= '" & txtPin.Text & "';"

It should be

Code:

command.CommandText = "SELECT * FROM TblUserName WHERE [UserName] = '" & txtUserName.Text & "' AND Pin= '" & txtPin.Text & "';"

or better still

Code:

command.CommandText = "SELECT * FROMFROM TblUserName WHERE UPPER([UserName]) LIKE '%" & txtUserName.Text.ToUpper & "%' AND UPPER(Pin) LIKE '%" & txtPin.Text.ToUpper & "%';"

**ogimy** · 03-18-2010 10:59 AM

easy mistake.very hard to find it.sorry i newbie thank

**JohnH** · 03-18-2010 5:17 PM

Originally Posted by ogimy

easy mistake.very hard to find it.

It's only hard to see because you made it so by complicating the code, parameterize the query:

Code:

.CommandText = "SELECT * FROM TblUserName WHERE [UserName] = @UserName AND Pin= @Pin"
.Parameters.AddWithValue("@UserName", txtUserName.Text)
.Parameters.AddWithValue("@Pin", txtPin.Text)

Other benefits include for example avoiding SQL injection.
Further recommendations: Data Walkthroughs and/or Forms over Data Video Series

Thread: simple log in program with database access

LinkBack

Thread Tools

Display

simple log in program with database access

Thread Information

Users Browsing this Thread

Bookmarks

Bookmarks

Posting Permissions